Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve UX for new households/users #4653

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

Prevents users from trying to create a household without selecting a group. Previously the UI would let you and silently fail (since no group was selected). Now the form won't submit.

Also disables selecting a household until group is selected on the user create page, with a new hint:
image

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #4632

@github-actions github-actions bot added the bugfix label Dec 1, 2024
Copy link
Collaborator

@Kuchenpirat Kuchenpirat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing.

frontend/pages/admin/manage/users/create.vue Outdated Show resolved Hide resolved
@Kuchenpirat Kuchenpirat self-assigned this Dec 2, 2024
@Kuchenpirat Kuchenpirat merged commit a439428 into mealie-recipes:mealie-next Dec 2, 2024
13 checks passed
@michael-genson michael-genson changed the title fix: Improve UX for new households/userrs fix: Improve UX for new households/users Dec 2, 2024
@michael-genson michael-genson deleted the fix/cant-create-households branch December 2, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Unable to create users / household
2 participants